Format fallback parameter names with the invariant culture - #1897
Merged
Conversation
parameterToNameLookup pins invariant formatting for the common types, but not sbyte, Int128, UInt128, BigInteger, nint or nuint. Those fell through to parameter.ToString(), which uses the ambient culture: under sv-SE with ICU ((sbyte)-5).ToString() is '\u22125' with U+2212 MINUS SIGN, so a theory parameterised on a negative value of one of those types named its received and verified files differently than the same test on CI. Fixed at the fallback rather than by extending the type list, so any formattable type is covered instead of only the ones someone remembered to add.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parameterToNameLookup pins invariant formatting for the common types, but not sbyte, Int128, UInt128, BigInteger, nint or nuint. Those fell through to parameter.ToString(), which uses the ambient culture: under sv-SE with ICU ((sbyte)-5).ToString() is '\u22125' with U+2212 MINUS SIGN, so a theory parameterised on a negative value of one of those types named its received and verified files differently than the same test on CI.
Fixed at the fallback rather than by extending the type list, so any formattable type is covered instead of only the ones someone remembered to add.