Release named recording state on dispose - #1898
Merged
Merged
Conversation
The named disposable only paused, so a scope left without an explicit Stop, for example because the test threw, left the State and every object it had recorded reachable forever through the static namedState dictionary. The unnamed variant is reclaimed with its execution context, but named state has nothing to reclaim it. It also blocked the identifier: identifiers are documented as statically unique, such as a fully qualified test name, so the next Start with the same one threw 'Recording already started', masking the original failure. Dispose now removes the entry, which stays a no-op after an explicit Stop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The named disposable only paused, so a scope left without an explicit Stop, for example because the test threw, left the State and every object it had recorded reachable forever through the static namedState dictionary. The unnamed variant is reclaimed with its execution context, but named state has nothing to reclaim it.
It also blocked the identifier: identifiers are documented as statically unique, such as a fully qualified test name, so the next Start with the same one threw 'Recording already started', masking the original failure.
Dispose now removes the entry, which stays a no-op after an explicit Stop.