Compile the MSTest generator against the Roslyn version it is packed for - #1899
Merged
Conversation
The generator was packed only into analyzers/dotnet/roslyn4.4, but its Microsoft.CodeAnalysis.CSharp reference had been bumped to 4.14.0 without the folder moving with it. Every compiler from 4.4 up to 4.13 therefore selected that folder and then skipped the assembly with CS9057, which is a warning. So [UsesVerify] generated nothing and each Verify call failed at run time with 'TestContext is null. Ensure test class has a [UsesVerify] attribute'. That covers VS 17.8 to 17.13, the .NET 8 LTS SDK, and .NET 9 SDKs before 9.0.300. The generator now compiles against 4.4 again, restoring the support floor the folder always claimed. It only uses APIs from 4.3 and earlier (ForAttributeWithMetadataName, WithTrackingName), so nothing is given up. Both the reference and the pack path now read one VerifyRoslynVersion property, so they cannot drift apart again. This replaces the CheckPackageVersion guard on Microsoft.CodeAnalysis.CSharp, which asserted the central version that this project no longer uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generator was packed only into analyzers/dotnet/roslyn4.4, but its Microsoft.CodeAnalysis.CSharp reference had been bumped to 4.14.0 without the folder moving with it.
Every compiler from 4.4 up to 4.13 therefore selected that folder and then skipped the assembly with CS9057, which is a warning. So [UsesVerify] generated nothing and each Verify call failed at run time with 'TestContext is null. Ensure test class has a [UsesVerify] attribute'. That covers VS 17.8 to 17.13, the .NET 8 LTS SDK, and .NET 9 SDKs before 9.0.300.
The generator now compiles against 4.4 again, restoring the support floor the folder always claimed. It only uses APIs from 4.3 and earlier (ForAttributeWithMetadataName, WithTrackingName), so nothing is given up.
Both the reference and the pack path now read one VerifyRoslynVersion property, so they cannot drift apart again. This replaces the CheckPackageVersion guard on Microsoft.CodeAnalysis.CSharp, which asserted the central version that this project no longer uses.