Nest snapshots under razor parents and Content items - #1909
Merged
Conversation
DependentUpon always pointed at <name>.cs. A Blazor test class sits in <name>.razor.cs, or in the <name>.razor itself, so nothing nested. The parent extension is now probed for, guarded on the project holding razor files so other projects pay nothing for it. The razor and web SDKs claim extensions like .json and .config as Content and remove them from None. Those items only exist once the SDK props have been evaluated, so Content nesting is applied from Verify.targets, and only where nothing has already set a parent. The snapshot glob also gained the default item excludes, so copies under bin and obj are no longer pulled into the project. VerifyTests/Verify.Bunit#108
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DependentUpon always pointed at .cs. A Blazor test class sits in .razor.cs, or in the .razor itself, so nothing nested. The parent extension is now probed for, guarded on the project holding razor files so other projects pay nothing for it.
The razor and web SDKs claim extensions like .json and .config as Content and remove them from None. Those items only exist once the SDK props have been evaluated, so Content nesting is applied from Verify.targets, and only where nothing has already set a parent.
The snapshot glob also gained the default item excludes, so copies under bin and obj are no longer pulled into the project.
VerifyTests/Verify.Bunit#108