You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add revocation index for multi-period attestation ranges keyed by merkle_root
Why this matters
revoke_multi_period_attestation performs a full linear scan of every range to find the matching merkle_root. With many ranges per business this becomes O(n) on every revocation. A secondary index from merkle_root to range index would make revocation O(1) and prevent storage rewrites of unchanged ranges.
Scope
Implement the requested behavior across contracts/attestation/src/lib.rs. The solution must preserve existing compatibility, authorization, and production safeguards.
Priority
High
Acceptance criteria
The requested behavior is implemented across contracts/attestation/src/lib.rs with a clear, reviewable contract.
Security, authorization, validation, and data-integrity requirements in the repository context are enforced and covered by tests.
Failure, retry, timeout, concurrency, and boundary behavior is explicit and produces safe, diagnosable outcomes where applicable.
Regression coverage includes empty, invalid, duplicate, and boundary inputs relevant to this flow.
Existing API, storage, and deployment compatibility is preserved unless a migration is explicitly documented.
Validation
Include focused tests for:
happy paths;
invalid input and authorization boundaries;
concurrency, retries, or failure recovery;
backward compatibility;
relevant integration or contract behavior.
The implementation must pass the repository’s existing build, lint, test, and formatting checks (use cargo test --all where applicable).
Non-goals
Typo-only, formatting-only, or documentation-only changes.
Unrelated refactors or dependency upgrades.
Weakening security, authorization, CI, or production safeguards.
Changing public behavior outside this issue’s scope.
Contributor application
Before implementation, comment with:
relevant experience;
a concise implementation approach;
expected files or modules affected;
an estimate for opening the first PR.
Wait for maintainer assignment before coding.
PR requirements
Use a feature branch and include Closes #.
The PR must:
address every acceptance criterion;
link each criterion to code and tests;
explain security and failure-mode handling;
include meaningful regression coverage;
document compatibility or migration considerations;
pass the repository checks.
Reward-readiness
This is a substantive quality issue. Merge status does not guarantee reward eligibility; final evaluation is determined separately.
Implementation context
Description
revoke_multi_period_attestation performs a full linear scan of every range to find the matching merkle_root. With many ranges per business this becomes O(n) on every revocation. A secondary index from merkle_root to range index would make revocation O(1) and prevent storage rewrites of unchanged ranges.
Summary
Add revocation index for multi-period attestation ranges keyed by merkle_root
Why this matters
revoke_multi_period_attestationperforms a full linear scan of every range to find the matchingmerkle_root. With many ranges per business this becomes O(n) on every revocation. A secondary index frommerkle_rootto range index would make revocation O(1) and prevent storage rewrites of unchanged ranges.Scope
Implement the requested behavior across contracts/attestation/src/lib.rs. The solution must preserve existing compatibility, authorization, and production safeguards.
Priority
High
Acceptance criteria
Validation
Include focused tests for:
The implementation must pass the repository’s existing build, lint, test, and formatting checks (use cargo test --all where applicable).
Non-goals
Contributor application
Before implementation, comment with:
Wait for maintainer assignment before coding.
PR requirements
Use a feature branch and include Closes #.
The PR must:
Reward-readiness
This is a substantive quality issue. Merge status does not guarantee reward eligibility; final evaluation is determined separately.
Implementation context
Description
revoke_multi_period_attestationperforms a full linear scan of every range to find the matchingmerkle_root. With many ranges per business this becomes O(n) on every revocation. A secondary index frommerkle_rootto range index would make revocation O(1) and prevent storage rewrites of unchanged ranges.Requirements and context
contracts/attestation/src/lib.rs(revoke_multi_period_attestation)MultiPeriodKey::RootIndex(business, root)containing the range position.Suggested execution
git checkout -b feat/multi-period-revocation-indexsubmit_multi_period_attestation.revoke_multi_period_attestationto look up via the index and mutate a single range.Test and commit
cargo test --allExample commit message
feat: add merkle_root index for multi-period revocationGuidelines