fix(circuit_breaker): remove anonymous failure reporting and restore Sybil resistance (closes #313) - #318
Open
guptakumarranjeet150 wants to merge 1 commit into
Conversation
…Sybil resistance (closes Vero-protocol#313) - Updates `BatchCall::RecordFailure(Address)` to carry an attributable reporter address, routing batch dispatch through the authenticated `Self::record_failure` path. - Removes the unauthenticated `record_failure_anonymous` helper from `src/circuit_breaker.rs`, restoring the documented anti-DoS Sybil barrier: `MAX_REPORTS_PER_REPORTER * (MIN_DISTINCT_REPORTERS - 1) <= FAILURE_THRESHOLD`. - Exposes `circuit_breaker` module publicly in `src/lib.rs` for constant auditing. - Updates `tests/circuit_breaker_dos.rs` to verify attributable batch execution, adds runtime assertion of the arithmetic Sybil barrier invariant, and asserts unauthenticated batch dispatches cannot increment `FailureCount`.
guptakumarranjeet150
requested review from
N-i-xx and
N-thnI
as code owners
September 11, 2026 15:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #313
Closes the anonymous failure-counter path in batch dispatch by requiring attributable reporter signatures and routing `BatchCall::RecordFailure(reporter)` through `record_failure(env, reporter)`. This restores the documented anti-DoS Sybil barrier (`MAX_REPORTS_PER_REPORTER * (MIN_DISTINCT_REPORTERS - 1) <= FAILURE_THRESHOLD`) preventing unauthenticated callers from manipulating the circuit-breaker state.
Key Changes
Verification