Add Ubuntu 24 Confluent headnode support#39
Conversation
viniciusferrao
force-pushed
the
feature/ubuntu24-headnode
branch
from
1f5769b to
5c599c5
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f5769bd2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case OS::Platform::ubuntu24: | ||
| return; |
There was a problem hiding this comment.
This unconditional ubuntu24 acceptance lets configurations proceed with provisioner=xcat, but the xCAT install path is still RPM-only (RepoManager::enable only implements RPM and XCAT::installPackages() runs dnf). On an Ubuntu 24.04 headnode, validation now passes and the run fails later during provisioning instead of being rejected up front. Please gate xCAT when the detected headnode package type is DEB (or surface a clear validation error before install starts).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in 8fc5d61: DEB headnodes now fail validation early with xCAT on DEB head nodes is not implemented yet; use confluent instead.
| imgutil exec $scratchdir <<EOF | ||
| DEBIAN_FRONTEND=noninteractive apt-get install -y chrony | ||
| sed -e '/^pool /d' -e '/^server .* iburst$/d' -i /etc/chrony/chrony.conf |
There was a problem hiding this comment.
The first Ubuntu node-image customization step runs apt-get install -y chrony inside the scratch image before any apt-get update has been executed in that chroot. On images where /var/lib/apt/lists is empty/stale (a common clean-image state), this fails with package resolution errors and aborts image creation before the later install block that does run apt-get update. Run apt-get update before these early Ubuntu installs (chrony/autofs) or fold them into the later updated block.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed in 8fc5d61: Ubuntu node-image chrony and autofs setup now runs apt update before the first apt install inside the scratch image.
viniciusferrao
force-pushed
the
feature/ubuntu24-headnode
branch
from
76a9146 to
eddcea2
Compare
viniciusferrao
force-pushed
the
feature/ubuntu24-headnode
branch
from
eddcea2 to
8fc5d61
Compare
1 participant
Summary
Validation
git diff --checkbash -n testing/libvirt/opencattus-el9-lab.sh testing/libvirt/opencattus-ubuntu24-lab.shrome01.local.versatushpc.com.brusingtesting/libvirt/opencattus-ubuntu24-lab.sh -c /home/ferrao/opencattus-ubuntu24-confluent-pr38.env runn01, Slurm reportedn01 idle, and the MPI smoke test returned both ranks fromn01: