Move away from sysvinit scripts to systemd#20
Merged
Conversation
viniciusferrao
changed the title
viniciusferrao
force-pushed
the
fix/systemd-xcatd
branch
6 times, most recently
from
7b963b2 to
5eec111
Compare
viniciusferrao
force-pushed
the
fix/systemd-xcatd
branch
from
5eec111 to
7897f30
Compare
dhilst
added a commit
that referenced
this pull request
Jun 1, 2026
…mkvm -f CI build #20 (AlmaLinux 10.1, libvirt-libs 11.10.0) failed the setup_vm test: `mkvm xcat01-cn -s 50G -f` aborted with Sys::Virt::StorageVol::delete(vol, flags) at .../kvm.pm line 316 In create_storage's force/recreate path, line 316 called `$_->delete()` on an existing volume WITHOUT first calling `get_info()`. On the newer Sys::Virt binding shipped on EL10 this transiently throws, so the VM was never recreated; the service node xcat01-sn never installed, producing 452 "No route to host" errors and ~91 cascading test failures (xdsh_*, xdcp_*, updatenode_*, restapi_*). This is the same failure mode already worked around at line ~1889 with the Issue xcat2#455 precedent: # Need to call get_info() before deleting a volume ... Issue xcat2#455 $vol->get_info(); $vol->delete(); Fix line 316 to mirror that precedent: refresh volume metadata with get_info() before delete(), wrap in eval, and on failure refresh the pool and retry once before dying with a clear message. Add the same get_info() guard to the other volume-delete sites in the chvm add-cleanup / purge paths and the clonevm rebase path for consistency. Validated with `perl -c` (full parse clean via stubbed deps; the only load-time errors are missing runtime xCAT modules, unrelated to the edit). No kvm unit tests exist in xCAT-test/unit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xcatd.servicestart/stop path instead of delegating to the SysV init script.initscripts/chkconfig.xcatconfig -i.perl:anydependencies there.Fixes xcat2#7343.
Validation
git diff --checksh -nandbash -nsh -nandbash -nxcatconfig -ixcatconfig -i; upgrade callsxcatconfig -u -Vperl -c xCAT-test/xcattestprove -v xCAT-test/unit/el10_netboot_dhcp_client.tprove -v xCAT-test/unit/el10_biosboot_partition.txCAT-server,xCAT,perl-xCAT, andxCAT-genesis-scriptsExecReload, start/restart/stop/start, package remove stops/disables, reinstall/start,lsxcatd -aperl-xcat,xcat-client,xcat-server, andxcatwith gzip compression and plainperldependencieslsxcatd -aNotes
systemd-analyze verifyemitted unrelated host unit warnings; noxcatd.serviceerrors were reported.