fix: remove Docker container lifecycle management (dead code since 2016)#31
Merged
Merged
Conversation
Docker container lifecycle management (mgt=docker, mkdocker, rmdocker, lsdocker) was added in 2015-2016 as an experiment targeting Docker API v1.22 on Ubuntu only. Documentation and man pages were deliberately removed in 2019 (PRs xcat2#6222 and xcat2#6324) with the original developer's approval, noting that "the interface of Docker has become very simple right now, so there is no value for xCAT to offer such functions." The plugin was still being shipped but has had no functional code changes since April 2016, was never listed as a valid mgt value in Schema.pm, and no user ever filed an issue about it. Removed: - xCAT-server/lib/xcat/plugins/docker.pm (1,142 lines) - xCAT/postscripts/setupdockerhost - xCAT-server/share/xcat/scripts/setup-dockerhost-cert.sh - xCAT-test/autotest/testcase/dockercommand/ (test cases) - Docker attribute definitions in Schema.pm - Client symlinks (mkdocker, rmdocker, lsdocker) - Usage entries and dockerhost cert handling in credentials.pm - Docker attribute documentation in man7 pages The "Running xCAT in Docker" documentation (dockerized_xcat/) is retained as it documents containerizing xCAT itself, not the removed mgt=docker feature. Closes xcat2#7518
Member
Author
Live Validation on cloyster (RHEL 8, xCAT 2.17.0)Verified on the lab management node that removing Docker lifecycle code has no impact on existing functionality. Environment
ResultsNo Docker nodes exist in the cluster: Docker attributes are already guarded — cannot be set without mgt=docker: VM/BMC commands unaffected: Existing Docker artifacts on 2.17.0 (to be removed on upgrade): Patched xcatconfig diff confirmed: Docker cert generation block cleanly removed, adjacent ConclusionZero Docker-managed nodes in production. Schema guard ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove Docker container lifecycle management (
mgt=docker,mkdocker,rmdocker,lsdocker) from xCAT.This was added in 2015-2016 as an experiment targeting Docker API v1.22 on Ubuntu only. Documentation and man pages were deliberately removed in 2019 (PRs xcat2#6222 and xcat2#6324) with the original developer's approval. The plugin has had no functional code changes since April 2016, was never listed as a valid
mgtvalue in Schema.pm, and no user has ever filed an issue about it.Changes
xCAT-server/lib/xcat/plugins/docker.pm(1,142 lines)xCAT/postscripts/setupdockerhostxCAT-server/share/xcat/scripts/setup-dockerhost-cert.shSchema.pmxcatconfigmkdocker,rmdocker,lsdocker) from RPM spec and debian linksUsage.pmandAAAusage.pmcredentials.pmxCATregThe "Running xCAT in Docker" documentation (
dockerized_xcat/) is retained — it documents containerizing xCAT itself, not the removedmgt=dockerfeature.Test plan
perl -c perl-xCAT/xCAT/Schema.pmpassesmkdocker/rmdocker/lsdocker/setupdockerhost/xcatdockerca/mgt=dockerCloses xcat2#7518