Show pending value when rspconfig SET readback differs

[viniciusferrao]

Summary

• On Supermicro (and potentially other) BMCs, a GET immediately after SET returns the old value
• rspconfig output was misleading: showed old value after setting new one
• Also fixes backupgateway SET writing to wrong IPMI parameter (0x0C instead of 0x0E)

Changes:

• Store canonical SET value after normalization, compare with GET readback
• When they differ, annotate: BMC Gateway: 10.20.0.1 (requested 10.20.0.254, not yet reflected)
• Consolidate ip/netmask/gateway/backupgateway display into one block
• Fix backupgateway SET to write parameter 0x0E (was silently writing primary gateway 0x0C)
• Readback comparison covers all four: ip, netmask, gateway, backupgateway
• ip=dhcp is unaffected — separate code path, never stores a comparison value

Test plan

All tests on Supermicro IPMI BMC, with inband recovery:

# gateway SET (stale readback on SMC firmware)
$ rspconfig smcbmc gateway=10.20.0.254
smcbmc: BMC Gateway: 10.20.0.1 (requested 10.20.0.254, not yet reflected)
# inband confirms SET worked:
$ ipmitool lan print 1 | grep Gateway
Default Gateway IP      : 10.20.0.254

# ip SET (static, stale readback)
$ rspconfig smcbmc ip=10.20.0.52
smcbmc: BMC IP: 10.20.0.51 (requested 10.20.0.52, not yet reflected)
# inband confirms SET worked:
$ ipmitool lan print 1 | grep IP
IP Address Source       : Static Address
IP Address              : 10.20.0.52

# backupgateway SET (now writes to correct parameter 0x0E)
$ rspconfig smcbmc backupgateway=10.20.0.2
smcbmc: BMC Backup Gateway: 10.20.0.2
# inband confirms backup gateway changed, primary untouched:
$ ipmitool lan print 1 | grep -i gateway
Default Gateway IP      : 10.20.0.1
Backup Gateway IP       : 10.20.0.2

# plain reads unchanged
$ rspconfig smcbmc ip
smcbmc: BMC IP: 10.20.0.51
$ rspconfig smcbmc netmask
smcbmc: BMC Netmask: 255.255.255.0
$ rspconfig smcbmc gateway
smcbmc: BMC Gateway: 10.20.0.1
$ rspconfig smcbmc backupgateway
smcbmc: BMC Backup Gateway: 0.0.0.0

perlcritic: no new findings (all pre-existing in ipmi.pm)

Fixes xcat2#3445

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de7d982462

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".