fix: prevent mkdef from creating partial objects on validation error#9
Merged
viniciusferrao merged 1 commit intoMay 7, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c16d99bb8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c2e1827 to
f006dc6
Compare
1a7df26 to
87deda2
Compare
408e37a to
a617035
Compare
a617035 to
2ae97c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes xcat2#3706.
Summary
only_ifvalidation failures as real object errors instead of only printing an error.updatedor written through%allupdates.mkdef -fremoves an existing definition.only_ifmatching and mkdef regression cases for partial writes and-fpreservation.Validation
prove -v xCAT-test/unit/dbobjutils_only_if.tperl -c perl-xCAT/xCAT/DBobjUtils.pmXCATROOT=/opt/xcat PERL5LIB=perl-xCAT:xCAT-server/lib/perl:xCAT-server/lib perl -c xCAT-server/lib/xcat/plugins/DBobjectdefs.pmgit diff --checkperlcritic --severity 5still reports existing findings already present onmaster; this patch did not introduce a new severity-5 class of issue in the touched files.