Fix: Classic Walking Animation#1261
Open
SprainedSpark89 wants to merge 131 commits into
Open
Conversation
probably the least known version of copyright hell
wasn't expecting someone to look
Co-authored-by: lowercasebtw <126462578+lowercasebtw@users.noreply.github.com>
lets try this pain once more
they fixed what isn't broke, I'M NOT HAPPY
I copied a fix from a new mod I'm making, but forgot to change the package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current classic walking animation in ViaFabricPlus visuals is only 1 half of the walking animation. The other half of the classic walking animation is in the Living Renderer, which it applies to all entities, which could be why it was never implemented in the first place.
Another option was also added as a very bad band-aid fix since there's an issue I did not know how to fix with the bobbing.
The issue was recently fixed, therefore the option can be removed.