Skip to content

Conversation

@noor-jafri
Copy link
Contributor

Hey Victor,

Here goes, map with provinces and administrative territories. Together they are called administrative units of Pakistan. Let me know if you would like to discuss about the naming convention.

I am also working with a team to go on a drill-down version for individual cities as well. For example, Karachi is gigantic and further divided into multiple districts. How can we cater cities so huge? :D Just a suggestion to use same wrapper you have written but maps for cities.

Copy link
Owner

@VictorCazanave VictorCazanave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution!

The naming looks good to me 👍

About the city maps, I think you can use the same naming convention as usa.utah package and call it pakistan.karachi.
However if you plan to add many cities, I'm worried that this repository will become messy mixing countries, states, cities... I also thought about it before merging Utah map, but at this time there were only few maps and I didn't expect much more 😅
Maybe the structure of the folders/packages should be reviewed. Or a new repository only for the cities of Pakistan could be created and a link added in this one 🤔
If needed, I can publish the script to generate the JS file from the SVG.

<svg
xmlns="http://www.w3.org/2000/svg"
viewBox="0 0 1628 1544"
aria-label="Map of Pakistan"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the label "Map of Pakistan provinces" or "Map of provinces and territories of Pakistan" please?

* Replace title by name attributes
* Use English names
* Add viewBox
* Rename ids
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also indicate that you removed the districts from the original map please?

@@ -0,0 +1,22 @@
{
"name": "@svg-maps/pakistan.provinces",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the package should be called paskitan.administrative-units to be more clear/consistent? 🤔I don't know if people really use this official name or just call them "provinces" .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants