added London-Boroughs#51
Conversation
VictorCazanave
left a comment
VictorCazanave
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution @bkrmalick ! 😃
As mentioned in the review, I would prefer to publish only 1 package with the right data, instead of 3 versions.
Then could you remove 2 variants and fix the small issues please?
| @@ -0,0 +1,23 @@ | |||
| { | |||
| "name": "@svg-maps/London-Boroughs", | |||
There was a problem hiding this comment.
Could you rename the folder and the package to be consistent with the other maps please?
packages/london.boroughs/ and @svg-maps/london.boroughs
There was a problem hiding this comment.
Could you fix the names please? It's london.boroughs in lower case with a dot (like france.regions, pakistan.districts...)
| @@ -0,0 +1,24 @@ | |||
| This is free and unencumbered software released into the public domain. | |||
There was a problem hiding this comment.
Did you confirm with Vega that their datasets are unlicensed? I would like to be sure they just didn't forget it 😅
| @@ -0,0 +1,36 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
Could you fix the SVG following the contribution guidelines (no <?xml version="1.0"?>, no width/height...) please?
There was a problem hiding this comment.
- indentation is missing
idof<path>tags cannot contain spaces and must be in kebab-casenameattributes of<path>tags are missing
|
Thank you for reviewing. I have resolved the small mentioned issues and removed the other variants leaving only the one with 33 boroughs (as that is that is the most appropriate one) I am unfortunately unsure of what Vega's reuse policy or licensing is. Regards, |
| .vscode | ||
| node_modules | ||
| packages/London-Boroughs 2 (Alternative) | ||
| packages/London-Boroughs 3 (Corrected to 32 boroughs) No newline at end of file |
There was a problem hiding this comment.
Could you remove this modification please?
|
Thank you for the quick fixing @bkrmalick ! |
|
I have removed the modificatins to gitignore file. I have found here that the LondonBoroughs map that Vega used was from this which is covered by the Open Government License :
Does that help? Regards, |
VictorCazanave
force-pushed
the
master
branch
from
da10c5a to
4309a09
Compare
2 participants
Needed London Borough level svg map
Converted topjson from here to svg and then to js 😪