app/vmui: fix mobile chart, time range, and layout issues#1626
Open
Loori-R wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 14 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Loori-R
force-pushed
the
vmui/fix-mobile-ui-issues
branch
from
July 23, 2026 13:25
3d4d4a3 to
a489528
Compare
Contributor
Author
Contributor
There was a problem hiding this comment.
1 issue found across 9 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/vmui/packages/vmui/src/components/Configurators/TimeRangeSettings/TimeSelector/style.scss">
<violation number="1" location="app/vmui/packages/vmui/src/components/Configurators/TimeRangeSettings/TimeSelector/style.scss:21">
P2: Scrollable content may be hidden behind the fixed-position controls bar at the bottom. The selector container has `overflow: auto` but no `padding-bottom` to account for the controls (~50-60px) that are taken out of flow, so the last items (e.g., TimeDurationSelector) can scroll underneath the fixed bar.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| border-bottom: $border-divider; | ||
| padding-bottom: $padding-global; | ||
|
|
||
| &__controls { |
Contributor
There was a problem hiding this comment.
P2: Scrollable content may be hidden behind the fixed-position controls bar at the bottom. The selector container has overflow: auto but no padding-bottom to account for the controls (~50-60px) that are taken out of flow, so the last items (e.g., TimeDurationSelector) can scroll underneath the fixed bar.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At app/vmui/packages/vmui/src/components/Configurators/TimeRangeSettings/TimeSelector/style.scss, line 21:
<comment>Scrollable content may be hidden behind the fixed-position controls bar at the bottom. The selector container has `overflow: auto` but no `padding-bottom` to account for the controls (~50-60px) that are taken out of flow, so the last items (e.g., TimeDurationSelector) can scroll underneath the fixed bar.</comment>
<file context>
@@ -17,6 +17,17 @@
border-bottom: $border-divider;
padding-bottom: $padding-global;
+
+ &__controls {
+ position: fixed;
+ right: 0;
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Describe Your Changes