Skip to content

app/vmui: fix mobile chart, time range, and layout issues#1626

Open
Loori-R wants to merge 4 commits into
masterfrom
vmui/fix-mobile-ui-issues
Open

app/vmui: fix mobile chart, time range, and layout issues#1626
Loori-R wants to merge 4 commits into
masterfrom
vmui/fix-mobile-ui-issues

Conversation

@Loori-R

@Loori-R Loori-R commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Describe Your Changes

  • Fixes bar chart touch interactions, including tap, pan, and pinch-to-zoom.
  • Prevents manually entered time ranges from shifting after applying them when the selected and local time zones differ.
  • Prevents horizontal page scrolling after opening menus on mobile devices.
  • Moves the time range control to the mobile header for quicker access.
  • Prevents horizontal page scrolling in mobile menus and JSON log views.

@Loori-R Loori-R added the web-ui Issues related to the user interface: layout, styling, usability, or UI-specific bugs. label Jul 23, 2026
@Loori-R Loori-R changed the title Vmui/fix mobile UI issues app/vmui: fix mobile chart, time range, and layout issues Jul 23, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 14 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread app/vmui/packages/vmui/src/hooks/uplot/useZoomChart.ts Outdated
@Loori-R
Loori-R force-pushed the vmui/fix-mobile-ui-issues branch from 3d4d4a3 to a489528 Compare July 23, 2026 13:25

@arturminchukov arturminchukov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

horizontal scroll appears in the JSON tab
Image

Enhacement suggestion:
I'd like to sugget move the time range control from the kebab menu to main screen. Why? Right now, IMO, there is no obvious way we can find this button. It's not related to this PR.

Image

@Loori-R

Loori-R commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

horizontal scroll appears in the JSON tab

Enhacement suggestion: I'd like to sugget move the time range control from the kebab menu to main screen. Why? Right now, IMO, there is no obvious way we can find this button. It's not related to this PR.

Updated. I moved the time range control from the menu to the main mobile header and added local scrolling to the JSON tab to prevent horizontal page overflow.

image

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 9 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="app/vmui/packages/vmui/src/components/Configurators/TimeRangeSettings/TimeSelector/style.scss">

<violation number="1" location="app/vmui/packages/vmui/src/components/Configurators/TimeRangeSettings/TimeSelector/style.scss:21">
P2: Scrollable content may be hidden behind the fixed-position controls bar at the bottom. The selector container has `overflow: auto` but no `padding-bottom` to account for the controls (~50-60px) that are taken out of flow, so the last items (e.g., TimeDurationSelector) can scroll underneath the fixed bar.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

border-bottom: $border-divider;
padding-bottom: $padding-global;

&__controls {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Scrollable content may be hidden behind the fixed-position controls bar at the bottom. The selector container has overflow: auto but no padding-bottom to account for the controls (~50-60px) that are taken out of flow, so the last items (e.g., TimeDurationSelector) can scroll underneath the fixed bar.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At app/vmui/packages/vmui/src/components/Configurators/TimeRangeSettings/TimeSelector/style.scss, line 21:

<comment>Scrollable content may be hidden behind the fixed-position controls bar at the bottom. The selector container has `overflow: auto` but no `padding-bottom` to account for the controls (~50-60px) that are taken out of flow, so the last items (e.g., TimeDurationSelector) can scroll underneath the fixed bar.</comment>

<file context>
@@ -17,6 +17,17 @@
     border-bottom: $border-divider;
     padding-bottom: $padding-global;
+
+    &__controls {
+      position: fixed;
+      right: 0;
</file context>

@arturminchukov arturminchukov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web-ui Issues related to the user interface: layout, styling, usability, or UI-specific bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants