app/vmui: vmalert ui for logs #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
force-pushed
the
vmalert-ui-for-logs
branch
2 times, most recently
from
3ed0814 to
c8dd6d1
Compare
Loori-R
requested changes
Jul 25, 2025
Contributor
Loori-R
left a comment
Loori-R
left a comment
There was a problem hiding this comment.
Overall looks good! I left a few comments, mostly around code style and structure.
app/vmui/packages/vmui/src/components/ExploreAlerts/Notifier/style.scss
Outdated
Show resolved
Hide resolved
app/vmui/packages/vmui/src/components/ExploreAlerts/Rule/index.tsx
Outdated
Show resolved
Hide resolved
app/vmui/packages/vmui/src/components/ExploreAlerts/RuleHeader/style.scss
Outdated
Show resolved
Hide resolved
app/vmui/packages/vmui/src/components/Main/Autocomplete/Autocomplete.tsx
Outdated
Show resolved
Hide resolved
app/vmui/packages/vmui/src/pages/ExploreAlerts/ExploreNotifiers.tsx
Outdated
Show resolved
Hide resolved
app/vmui/packages/vmui/src/pages/ExploreAlerts/ExploreNotifiers.tsx
Outdated
Show resolved
Hide resolved
app/vmui/packages/vmui/src/pages/ExploreAlerts/ExploreRules.tsx
Outdated
Show resolved
Hide resolved
app/vmui/packages/vmui/src/pages/ExploreAlerts/ExploreRules.tsx
Outdated
Show resolved
Hide resolved
1 task
AndrewChubatiuk
force-pushed
the
vmalert-ui-for-logs
branch
11 times, most recently
from
6162b2b to
9fed494
Compare
AndrewChubatiuk
force-pushed
the
vmalert-ui-for-logs
branch
8 times, most recently
from
6720eeb to
bdbe818
Compare
arturminchukov
requested changes
Aug 26, 2025
app/vmui/packages/vmui/src/pages/ExploreAlerts/ExploreNotifiers.tsx
Outdated
Show resolved
Hide resolved
app/vmui/packages/vmui/src/pages/ExploreAlerts/ExploreRules.tsx
Outdated
Show resolved
Hide resolved
app/vmui/packages/vmui/src/pages/ExploreAlerts/ExploreRules.tsx
Outdated
Show resolved
Hide resolved
app/vmui/packages/vmui/src/pages/ExploreAlerts/ExploreRules.tsx
Outdated
Show resolved
Hide resolved
app/vmui/packages/vmui/src/pages/ExploreAlerts/ExploreRules.tsx
Outdated
Show resolved
Hide resolved
app/vmui/packages/vmui/src/pages/ExploreAlerts/ExploreRules.tsx
Outdated
Show resolved
Hide resolved
AndrewChubatiuk
force-pushed
the
vmalert-ui-for-logs
branch
2 times, most recently
from
dfa790d to
d9ae79d
Compare
AndrewChubatiuk
force-pushed
the
vmalert-ui-for-logs
branch
4 times, most recently
from
5360ab6 to
3287c6f
Compare
hagen1778
approved these changes
Sep 1, 2025
AndrewChubatiuk
force-pushed
the
vmalert-ui-for-logs
branch
2 times, most recently
from
144b38f to
f22b9f1
Compare
AndrewChubatiuk
force-pushed
the
vmalert-ui-for-logs
branch
from
f22b9f1 to
68e8074
Compare
valyala
added a commit
that referenced
this pull request
Sep 17, 2025
Reason for revert: this functionality is non-trivial, so it needs additional maintenance efforts in the future. This functionality is non-core for VictoriaLogs web UI (aka 'nice to have feature'). It is already provided by vmalert web UI ( https://docs.victoriametrics.com/victoriametrics/vmalert/#web ). I doubt we'll have enough capacity for providing high-quiality maintenance for this functionality. It is better to revert it instead of providing half-baked functionality for our users. Updates #522 Updates VictoriaMetrics/VictoriaMetrics#8989 Updates #5
Contributor
|
@hagen1778 , @AndrewChubatiuk , this pull request has been reverted in the commit 88e9e3c . See the commit message description for details on why this commit has been reverted. TL;DR: this pull request implements non-essential functionality, which is already implemented partially at vmalert web UI. This functionality is non-trivial and requires a lot of code changes. These code changes may negatively impact code maintenance in the future and take non-trivial amounts of additional time for the maintenance. I doubt we'll be able to maintain this functionality at the usable level in the long run. @hagen1778 , @makasim please consider reverting the similar functionality at VictoriaMetrics web UI (see VictoriaMetrics/VictoriaMetrics#8989 ) because of the same reasons. |
Contributor
|
It is very important that all the pull requests satisfy our development goals at https://docs.victoriametrics.com/victoriametrics/goals/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Implements VMAlert UI tab for logs, depends on API from #5 and similar to VictoriaMetrics/VictoriaMetrics#8989
Checklist
The following checks are mandatory: