Skip to content

Conversation

@AndrewChubatiuk
Copy link
Contributor

Describe Your Changes

upgrading golangci-lint

Checklist

The following checks are mandatory:

Copy link
Member

@vadimalekseev vadimalekseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewChubatiuk AndrewChubatiuk merged commit 9394794 into master Jul 9, 2025
8 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the golang-ci-lint-upgrade branch July 9, 2025 06:46
valyala added a commit that referenced this pull request Jul 14, 2025
…to understand code

Revert changes made at app/vlinsert/journald/journald.go in the commit 9394794,
since these changes complicate understanding the code:

    if !(c >= 'A' && c <= 'Z' || c >= '0' && c <= '9' || c == '_')

is easier to understand and maintain than

    if (c < 'A' || c > 'Z') && (c < '0' || c > '9') && c != '_'

This is a follow-up for #6
@valyala
Copy link
Contributor

valyala commented Jul 14, 2025

@AndrewChubatiuk , @vadimalekseev , please see the follow-up commit 8577d40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants