app/vmui: properly show tenant info if AccountID and ProjectID headers are set by proxy or remove it completely #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valyala
reviewed
Sep 11, 2025
docs/victorialogs/CHANGELOG.md
Outdated
|
|
||
| ## tip | ||
|
|
||
| * FEATURE: [web UI](https://docs.victoriametrics.com/victorialogs/querying/#web-ui): set proper tenant information, when `AccountID` and `ProjectID` headers are set by a proxy or completely hide it in UI if `-select.disableTenantResponseHeaders` flag is set. See [#656](https://github.com/VictoriaMetrics/VictoriaLogs/issues/656) |
Contributor
There was a problem hiding this comment.
It looks like the pull request misses the implementation for the -select.disableTenantResponseHeaders command-line flag.
Contributor
Author
There was a problem hiding this comment.
added it here as it introduces this vmui feature config
Contributor
Author
There was a problem hiding this comment.
@valyala completely removed -select.disableTenantResponseHeaders flag as this behaviour can be fully controlled by vmauth, updated PR description
AndrewChubatiuk
force-pushed
the
properly-display-or-hide-tenant-info
branch
from
f678a2a to
d310e59
Compare
…s are set by proxy
AndrewChubatiuk
force-pushed
the
properly-display-or-hide-tenant-info
branch
from
d310e59 to
ff72e15
Compare
valyala
added a commit
that referenced
this pull request
Sep 17, 2025
…D headers are set by proxy or remove it completely (#664)" This reverts commit 97ffbff. Reason for revert: this functionality depends on the commit 2d4b343 , which is going to be reverted. The reason for reverting the 2d4b343 is that it mixes multiple unrelated features in a single commit. This functionality must be implemented in a distinct pull request dedicated solely for this functionality at both VictoriaLogs server side and VictoriaLogs web UI. Updates #664 Updates #5 Updates #656
Contributor
|
FYI, this pull request has been reverted in 0463c2a . See the commit message description for details why this pull request has been reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #5
fixes #656
Describe Your Changes
show properly tenant information based on response headers while querying
/select/vmui/config.json:AccountIDandProjectIDresponse headers are set tenant information is displayed as a static label, which doesn't allow to select custom tenantVL-Disable-Tenant-Controlsresponse header is set totruetenant information is hidden on VMUI.Please provide a brief description of the changes you made. Be as specific as possible to help others understand the purpose and impact of your modifications.
Checklist
The following checks are mandatory: