-
Notifications
You must be signed in to change notification settings - Fork 61
logstorage: support GetTenants low level API #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… GetTenantIDs in storage_search.go; Renamed some variables.
|
Thanks for the valuable review comments. They're addressed in a273ad4, with an extra unit test for the new function in |
|
@dmitryk-dk I'll rebase your branch once this pull request is merged, since there're a lot of changes by review suggestions already. |
|
Thanks again. The review comments are addressed in f3f2a4b. PTAL again. In the mean time, I noticed variable name VictoriaLogs/lib/logstorage/storage_search.go Line 1228 in f3f2a4b
Let me know if you want it to be renamed to |
This should be fixed for the sake of consistency. Please fix this in a separate pull request. |
|
@jiekun , thank you for the pull request! |
Describe Your Changes
Expose
GetTenantsfunction inlogstorage. It provides a way to get the tenants by time range for projects who uselogstorage, such as VictoriaTraces.The implementation is stolen from #417. Only HTTP API related codes are excluded. The HTTP API could be decided in #417 later without blocking this one.
The CHANGELOG was intentionally left blank, as this feature is not exposed to users.
Checklist
The following checks are mandatory: