-
Notifications
You must be signed in to change notification settings - Fork 57
vlagent: implement Kubernetes log collector #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9a03420 to
faedb5b
Compare
valyala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall!
@vadimalekseev , please document the added functionality in docs/victorialogs/vlagent.md, and mention it at docs/victorialogs/CHANGELOG.md.
faedb5b to
ceeb226
Compare
|
maybe makes sense to move k8s client configuration from this PR and https://github.com/VictoriaMetrics/VictoriaMetrics/blob/1a68d4ac8a032dfa96cea8b984e17a3cb23f825d/lib/promscrape/discovery/kubernetes/kubeconfig.go to a separate package |
9c17ba6 to
b44ea2d
Compare
|
Added documentation.
upd:
|
e704457 to
4d6b440
Compare
4fe8d5f to
bedc0a7
Compare
f9a9997 to
1c3b7b4
Compare
8757ae4 to
fbc8332
Compare
fbc8332 to
01cb965
Compare
|
@vadimalekseev , thank you for implementing discovery and collecting of logs in Kubernetes by |
Describe Your Changes
Fixes: #538
Checklist
The following checks are mandatory: