Skip to content

Conversation

@manute
Copy link

@manute manute commented Dec 10, 2025

Describe Your Changes

#718
Add IsPartial to Querystats for partial-response header

Checklist

The following checks are mandatory:

@func25
Copy link
Contributor

func25 commented Dec 10, 2025

Thanks for the PR, this is a good start, but the current approach is mixing two different concepts:

allow_partial_response is a user option that controls how we handle errors from some storage nodes.
IsPartial (and the VL-Partial-Response header) should reflect the actual outcome of the query: whether the response was built from all backends or some were unavailable and we returned a partial result.

In other words, IsPartial shouldn't just mirror allow_partial_response. It needs to be derived from the cluster error‑handling logic (where we already know which vlstorage nodes failed and whether we still returned a result) and then aggregated across nodes via QueryStats. Once that is in place, the HTTP handlers can read QueryStats.IsPartial and set VL-Partial-Response appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants