Skip to content

app/vlinsert/{loki,opentelemetry}: call clear() on the entire slice fields slice #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vadimalekseev wants to merge 1 commit into from
Closed

app/vlinsert/{loki,opentelemetry}: call clear() on the entire slice fields slice #891

vadimalekseev wants to merge 1 commit into from

Conversation

@vadimalekseev
Copy link
Member

@vadimalekseev vadimalekseev commented Dec 11, 2025

Call clear() on the entire slice before exiting the function to guarantee the release of all held references to the input byte slice.

Related: #869

@vadimalekseev
call clear() on the entire slice before exiting the function to guara…
23e370f 
…ntee the release of all held references to the input byte slice
@vadimalekseev vadimalekseev deleted the clear-fields branch December 11, 2025 10:52
@vadimalekseev
Copy link
Member Author

vadimalekseev commented Dec 11, 2025

Replaced with 63a68ed

valyala added a commit that referenced this pull request Dec 11, 2025
@valyala
lib/logstorage: add Fields.ClearUpToCapacity() function for clearing …
8542d5b 
…all the fields up to Fields.Fields capacity

Use this function in cases when references to the underlying byte slice at Fields.Fields entries must be cleared,
so the underlying byte slice could be released by Go GC.

This is a follow-up for 63a68ed

See also #891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valyala valyala Awaiting requested review from valyala

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vadimalekseev