app/vlselect: introduce -vmalert.proxyURL flag to proxy /api/v1/notifiers, /api/v1/alerts and /api/v1/rules requests to VMAlert #9268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iers, /api/v1/alerts and /api/v1/rules requests to VMAlert
1 task
Haleygo
approved these changes
Jun 27, 2025
AndrewChubatiuk
force-pushed
the
vlselect-proxy-vmalert-requests
branch
from
5778668 to
c032e53
Compare
Contributor
Contributor
Author
Since there's no consensus on ability to use the same vmalert instance for multiple datasource types such filtering is not required at the moment |
Contributor
Author
|
closing this PR and opened another one in VictoriaLogs repo instead |
Contributor
|
We should filter alerts to include only those related to the specific product (either metrics or logs). Returning metrics-related alerts or rules through a VictoriaLogs instance doesn't make much sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Please provide a brief description of the changes you made. Be as specific as possible to help others understand the purpose and impact of your modifications.
Checklist
The following checks are mandatory: