-
Notifications
You must be signed in to change notification settings - Fork 394
distributed: allow targeting extra vmagent to vmsingle/vmcluster directly #2526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
4d1143d to
b5f67ee
Compare
d782457 to
e6e34ad
Compare
391eb7c to
6c68900
Compare
e6e34ad to
37d503e
Compare
6c68900 to
706bb6b
Compare
37d503e to
f6df877
Compare
|
@AndrewChubatiuk could you explain the purpose of this PR? And why / how is it related to the issue linked? |
|
@YuryHrytsuk updated description |
Thanks What confuses me is word mixed balancer. Based on what I read, to write data to VM Single / Cluster, one uses So word mixed implies that there is only one entity doing both? But if |
f6df877 to
1980cab
Compare
1980cab to
c08be65
Compare
|
this PR introduces ability to set remoteWrites for |
c08be65 to
11cb9e2
Compare
|
@AndrewChubatiuk please check fix for extra vmagent |
da17148 to
a7fd168
Compare
Haleygo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
Let's merge it if you're ok with my commits.
| retry_status_codes: [500, 502, 503] | ||
| drop_src_path_prefix_parts: 2 | ||
| src_paths: | ||
| - /select/.+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default src_paths for vmsingle read&write look a bit weird though.
See
and #2517 (comment)
|
a842d33 to
141fdd6
Compare


writeandrwbalancers are disabled (related issue feature:victoria-metrics-k8s-stackallow multiple vmsingle replicas (servers) #2517)