Skip to content

strings extraction: extract values with custom UTF encoding from strings#28

Open
zekker6 wants to merge 1 commit intomasterfrom
decode-utf-characters-from-strings
Open

strings extraction: extract values with custom UTF encoding from strings#28
zekker6 wants to merge 1 commit intomasterfrom
decode-utf-characters-from-strings

Conversation

@zekker6
Copy link
Member

@zekker6 zekker6 commented Feb 29, 2024

Previously, only quoted values of UTF escaped sequences were converted into UTF runes due to Go strings semantics. Also, it would not decode values with non-standard Go escaping.

This change adds additional decoding logic to always convert escape sequence into character.

See also: VictoriaMetrics/VictoriaMetrics#5519

@zekker6 zekker6 requested a review from valyala February 29, 2024 15:46
Previously, only quoted values of UTF escaped sequences were converted into UTF runes due to Go strings semantics. Also, it would not decode values with non-standard Go escaping.

This change adds additional decoding logic to always convert escape sequence into character.

See also: VictoriaMetrics/VictoriaMetrics#5519
@zekker6 zekker6 force-pushed the decode-utf-characters-from-strings branch from f0485f8 to e6e2f46 Compare December 3, 2025 13:18
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.63%. Comparing base (6ea382c) to head (e6e2f46).

Files with missing lines Patch % Lines
lexer.go 85.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   89.05%   89.63%   +0.58%     
==========================================
  Files          11       11              
  Lines        3681     3010     -671     
==========================================
- Hits         3278     2698     -580     
+ Misses        306      212      -94     
- Partials       97      100       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zekker6 zekker6 requested review from f41gh7 and makasim December 3, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant