added a single operator_bad_objects_total for bad objects managed by VMAgent, VMAuth, VMAlert and VMAlertmanager
#1676
+884
−1,056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
requested review from
Haleygo,
f41gh7 and
vrutkovs
as code owners
AndrewChubatiuk
force-pushed
the
add-more-metrics
branch
12 times, most recently
from
f0d2405 to
9236ffb
Compare
f41gh7
reviewed
Dec 8, 2025
vrutkovs
reviewed
Dec 9, 2025
vrutkovs
approved these changes
Dec 9, 2025
f41gh7
reviewed
Dec 9, 2025
f41gh7
reviewed
Dec 9, 2025
f41gh7
reviewed
Dec 9, 2025
| AsKey(bool) string | ||
| } | ||
|
|
||
| type ChildObjects[T scrapeObjectWithStatus] struct { |
Collaborator
There was a problem hiding this comment.
There is no any kind of documentation to the public exported methods.
Contributor
Author
There was a problem hiding this comment.
added comments
AndrewChubatiuk
changed the title
operator_bad_objects_count for bad objects managed by VMAgent, VMAuth, VMAlert and VMAlertmanageroperator_bad_objects_total for bad objects managed by VMAgent, VMAuth, VMAlert and VMAlertmanager
AndrewChubatiuk
force-pushed
the
add-more-metrics
branch
5 times, most recently
from
2102ece to
bb34914
Compare
This commit adds object_namespace label to the metrics: * operator_alertmanager_bad_objects_count * operator_vmalert_bad_objects_count It helps to route alerts on object_namespace label.
Signed-off-by: f41gh7 <[email protected]>
AndrewChubatiuk
force-pushed
the
add-more-metrics
branch
from
bb34914 to
b528ca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR built on #1671
unify child objects managenent for VMAgent, VMAuth, VMAlert and VMAlertsmanager