config-reloader: removed 3rd-party config reloaders #1683
+170
−447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
requested review from
Haleygo,
f41gh7 and
vrutkovs
as code owners
AndrewChubatiuk
force-pushed
the
removed-3rd-party-reloaders
branch
from
fd4a2dc to
2ca5b55
Compare
AndrewChubatiuk
force-pushed
the
removed-3rd-party-reloaders
branch
from
2ca5b55 to
318c01b
Compare
vrutkovs
reviewed
Dec 12, 2025
| // UseVMConfigReloader replaces prometheus-like config-reloader | ||
| // with vm one. It uses secrets watch instead of file watch | ||
| // which greatly increases speed of config updates | ||
| // Deprecated: this property is ignored and no longer needed |
Contributor
There was a problem hiding this comment.
Suggested change
| // Deprecated: this property is ignored and no longer needed | |
| // Removed since 0.67.0: this property is ignored and no longer needed |
Contributor
There was a problem hiding this comment.
It would be useful to mention when this was deprecated (not sure if its a common practice in the repo already)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed 3rd-party config reloaders
prepared PR to be merged once we're ready for it