Skip to content

Conversation

@dmitryk-dk
Copy link
Contributor

@dmitryk-dk dmitryk-dk commented Dec 4, 2025

Enable the tenants selector into the datasource settings.
Screenshot 2025-12-05 at 13 26 07
If the backend doesn't support the endpoint the previous inputs will be used
image

Related issue: #475

@dmitryk-dk dmitryk-dk marked this pull request as ready for review December 5, 2025 12:27
@Loori-R
Copy link
Contributor

Loori-R commented Dec 5, 2025

Do I understand correctly that the user can select ProjectID and AccountID independently from each other?
Shouldn’t they be selected as a pair (i.e., only valid ProjectID:AccountID combinations)?

@dmitryk-dk
Copy link
Contributor Author

Do I understand correctly that the user can select ProjectID and AccountID independently from each other? Shouldn’t they be selected as a pair (i.e., only valid ProjectID:AccountID combinations)?

yep. But if we have

{[accountid:5, projectid:1], [accountid: 5, projectid:2], [accountid: 5, projectid:3]}

which to choose (first)?
If yes i will update the logic

@Loori-R
Copy link
Contributor

Loori-R commented Dec 5, 2025

I think the simplest approach is to have a single selector with values in the AccountID:ProjectID format (same as in vmui and the format returned by VictoriaMetrics). This way the user always selects a valid pair.

An alternative would be to keep two fields and filter ProjectID options based on the selected AccountID, but this seems less convenient - the user would first have to change the AccountID in order to access a different ProjectID.

@dmitryk-dk
Copy link
Contributor Author

I think the simplest approach is to have a single selector with values in the AccountID:ProjectID format (same as in vmui and the format returned by VictoriaMetrics). This way the user always selects a valid pair.

An alternative would be to keep two fields and filter ProjectID options based on the selected AccountID, but this seems less convenient - the user would first have to change the AccountID in order to access a different ProjectID.

Oki doki, will update to one selector :)

Copy link
Contributor

@Loori-R Loori-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@arturminchukov arturminchukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmitryk-dk dmitryk-dk merged commit 44466e7 into main Dec 8, 2025
8 checks passed
@arturminchukov arturminchukov deleted the add-tenant-selector branch December 9, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants