fix issue with many of the filter fileds and values #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use lodash debounce, fix parsing use memoization to avoid errors on render fix render for Grafana < 11 simplify check update CHANGELOG.md
* implement Combobox for different versions of Grafana implement two types of compatible combobox fix usage of the components cleanup update CHANGELOG.md * fix nit comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #357
Describe Your Changes
Replaced Select with Combobox — the new recommended component in Grafana UI, which has built-in virtualization.
Implemented async loading — Combobox supports an options function that returns a Promise<ComboboxOption[]>. Options are loaded when the dropdown opens and when text is entered.
Added debounced search — a 300ms delay during search to prevent request spamming.
Client-side caching and filtering:
All fields are loaded once on the first open
Subsequent searches filter the already loaded data locally
Display limit — 1000 options (MAX_VISIBLE_OPTIONS)
Checklist
The following checks are mandatory: