Combobox component #493
Merged
Combobox component #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement two types of compatible combobox fix usage of the components cleanup update CHANGELOG.md
dmitryk-dk
force-pushed
the
combobox-component
branch
from
076f859 to
e8798ab
Compare
# Conflicts: # src/components/QueryEditor/QueryBuilder/components/QueryBuilderFilters/QueryBuilderFieldFilter.tsx
arturminchukov
approved these changes
Dec 9, 2025
Contributor
arturminchukov
left a comment
arturminchukov
left a comment
There was a problem hiding this comment.
LGTM! just few nit comments.
dmitryk-dk
added a commit
that referenced
this pull request
Dec 10, 2025
* fix issue with many of the filter fileds and values use lodash debounce, fix parsing use memoization to avoid errors on render fix render for Grafana < 11 simplify check update CHANGELOG.md * remove unused state * Combobox component (#493) * implement Combobox for different versions of Grafana implement two types of compatible combobox fix usage of the components cleanup update CHANGELOG.md * fix nit comments * fix fe tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: this is mostly followup commit after adding tenant fetch support
Describe Your Changes
To be compatible with Grafana < 11 version, we need to support components Select, AsyncSelect, and Combobox.
Implemented a component which checks the availability of the Combobox component and uses it if it can be used, or use the old Select or AsyncSelect
Checklist
The following checks are mandatory: