feat: add opt-in dataplane format#596
Open
github-vincent-miszczak wants to merge 1 commit intoVictoriaMetrics:mainfrom
Open
feat: add opt-in dataplane format#596github-vincent-miszczak wants to merge 1 commit intoVictoriaMetrics:mainfrom
github-vincent-miszczak wants to merge 1 commit intoVictoriaMetrics:mainfrom
Conversation
46386d1 to
e49b2ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an opt-in setting and the corresponding UI toggle to enable logs dataplane format.
Using this format allows Grafana correlations to work correctly with label values.
Without it, it's not possible to craft links that use label values when using Grafana correlations.
It's opt-in because the fields are renamed, which may break client-side transformations.
Summary by cubic
Adds an opt-in setting to output logs in Grafana dataplane format, enabling automatic
${labelKey}variables in correlations. Default is off to avoid breaking transformations that referenceTime/Line.jsonData.useDataplaneFormat.Time→timestampandLine→body, and set frame meta toDataFrameType.LogLineswithtypeVersion [0,0]so${labelKey}works in correlations.Written for commit e49b2ea. Summary will update on new commits.