Skip to content

chore: fix linting #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

samidarko
Copy link
Contributor

@samidarko samidarko commented Mar 27, 2025

I've been trying to fix the lint error. The first run showed more than 3000 errors.

There are way too many line too long (E501) and too complex functions (C901) so I excluded those rule completely in the pyproject.toml.

More importantly, the errors left are more linked to the code and I'm not feeling comfortable fixing them. I think it would be better if you do it.

Please take a look this missing dependency:

$ poetry run lint | grep videotuna | egrep -v "F841|F821|F811|F405"
videotuna/lvdm/modules/losses/contperceptual.py:4:1: F403 `from taming.modules.losses.vqperceptual import *` used; unable to detect undefined names
120 |         from videotuna.third_party.flux.models.smoldit import (

Next it's important to fix all those rules because it's some programming errors.

Here are the Ruff lint rule names for the specified error codes:

Code Rule Name Description
F841 unused-variable Variable is assigned but never used.
F821 undefined-name Name is used but not defined.
F811 redefined-while-unused Variable is redefined while the original was never used.
F405 undefined-from-import Import * statement used but name is undefined.

These rules belong to the Pyflakes (F) category in Ruff.

@samidarko samidarko force-pushed the lint-fix branch 2 times, most recently from f49b48c to 22fc5a7 Compare March 27, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant