Change Database class initialisation process#2121
Merged
barijaona merged 3 commits intoViennaRSS:masterfrom Apr 19, 2026
Merged
Change Database class initialisation process#2121barijaona merged 3 commits intoViennaRSS:masterfrom
barijaona merged 3 commits intoViennaRSS:masterfrom
Conversation
barijaona
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #2083.
I believe it is not a good idea to call all the database setup code within the
dispatch_onceblock of the singleton initialiser. I have seen several instances where an exception is thrown or the app will just crash if objects that are meant to be accessed on the main thread are accessed from within that block.In anticipation of #2063 I investigated which database code is accessed during the loading process of the view hierarchy and found that only the
arrayOfFields/fieldByNameaccessors are read, which don't require the SQLite database to be loaded. I therefore reduced the Database initialiser to just initialise the class and ivars and moved the database setup code into a separate‑loadDatabaseStoremethod that is called from‑applicationDidFinishLaunching:. I madearrayOfFields/fieldByNamelazily loaded and simplified the Field initialisation code by adding a convenience initialiser.