Fix issue 2123: fine tune detection of articles evicted from cache#2127
Open
barijaona wants to merge 4 commits intoViennaRSS:stablefrom
Open
Fix issue 2123: fine tune detection of articles evicted from cache#2127barijaona wants to merge 4 commits intoViennaRSS:stablefrom
barijaona wants to merge 4 commits intoViennaRSS:stablefrom
Conversation
We cannot blindly trust the `isCached` property as objects in NSCache may be evicted at any time. Fix issue ViennaRSS#2123: articles not being marked read as expected
barijaona
changed the title
barijaona
changed the title
Limit costly back-and-forth reciprocal calls between Folder's -ensureCache and the database.
Makes it clearer that the function does not update articles in memory, so the caller must do it itself if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.