Fix setting custom preview_paths

[tvdeyen]

Setting preview_paths to anything else than test/components/previews is broken, because we mutate ActiveSupport::Dependencies.autoload_paths.

From the Rails guides:

Please do not mutate ActiveSupport::Dependencies.autoload_paths;
the public interface to change autoload paths is config.autoload_paths.

Fixes #365

[Spone]

Wow thanks for this! Any idea why the CI is failing?

EDIT: also, can you add a changelog entry for this?

[tvdeyen]

Wow thanks for this! Any idea why the CI is failing?

No. It seems it is broken for a long time https://github.com/ViewComponent/view_component/actions/workflows/ci.yml
Probably the Rails 8.0 release? Since the main branch is not building it seems very unlikely that the issues are related with this change tbh. I recommend that a maintainer fixes the issues on current main first.

EDIT: also, can you add a changelog entry for this?

Sure. Can do.

[tvdeyen]

@Spone so, specs seem to fail because of #1659

action_view loaded too soon

is the error and then it exits. I assume that due to the fact that we now add preview_paths to autoload_paths way earlier (before :set_autoload_paths from Rails). My guess is that this loads ActionView::Base somehow.

We need to be that early though, because autoload_paths is frozen after :set_autoload_paths which causes #365

I don't know which problem #1659 solves. Maybe @camertron can shed some light?

[joelhawksley]

I have yet to be able to reproduce this issue, despite trying to do so in a greenfield Rails app and in tests on this repo: #2294. Closing.

I'd be more than happy to pair with anyone who can reproduce it on their end!