Skip to content

Add layout attribute POC#2232

Closed
reeganviljoen wants to merge 3 commits intoViewComponent:mainfrom
reeganviljoen:rv-add-layout
Closed

Add layout attribute POC#2232
reeganviljoen wants to merge 3 commits intoViewComponent:mainfrom
reeganviljoen:rv-add-layout

Conversation

@reeganviljoen
Copy link
Copy Markdown
Collaborator

@reeganviljoen reeganviljoen commented Mar 19, 2025

closses #2173

What are you trying to accomplish?

As per #2173 this adds a layout attribute, the main difference is that this monkey patches rails's render_in instead of making use of an upstream addition, this is supposed to act as a POC to strat the discusion about how the api looks like and top start next steps to get this done

Anything you want to highlight for special attention from reviewers?

This is not to be merged in its current state but to start the discusion for the api's implementation in view component and rails and how to achieve this

@reeganviljoen
Copy link
Copy Markdown
Collaborator Author

@joelhawksley I haven't done anything in a while and this POC was easy enough to setup to get my feet wet again, please have a look when you can

@joelhawksley joelhawksley marked this pull request as draft March 19, 2025 17:43
@joelhawksley
Copy link
Copy Markdown
Member

Marking as draft as this is not meant to be merged ❤️

@reeganviljoen
Copy link
Copy Markdown
Collaborator Author

thank you @joelhawksley
please feel free to add some feedback, before I submit a pull request to rails
cc @boardfish

@joelhawksley
Copy link
Copy Markdown
Member

Thanks for documenting this issue, I'll add it as a TODO to v4.

@joelhawksley joelhawksley mentioned this pull request May 7, 2025
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants