Add layout attribute POC#2232
Closed
reeganviljoen wants to merge 3 commits intoViewComponent:mainfrom
Closed
Conversation
Collaborator
Author
|
@joelhawksley I haven't done anything in a while and this POC was easy enough to setup to get my feet wet again, please have a look when you can |
Member
|
Marking as draft as this is not meant to be merged ❤️ |
Collaborator
Author
|
thank you @joelhawksley |
Member
|
Thanks for documenting this issue, I'll add it as a TODO to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closses #2173
What are you trying to accomplish?
As per #2173 this adds a layout attribute, the main difference is that this monkey patches rails's
render_ininstead of making use of an upstream addition, this is supposed to act as a POC to strat the discusion about how the api looks like and top start next steps to get this doneAnything you want to highlight for special attention from reviewers?
This is not to be merged in its current state but to start the discusion for the api's implementation in view component and rails and how to achieve this