Skip to content

remove unused code path in template.rb #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joelhawksley merged 1 commit into from
Mar 27, 2025
Merged

remove unused code path in template.rb #2247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions lib/view_component/template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
module ViewComponent
class Template
DataWithSource = Struct.new(:format, :identifier, :short_identifier, :type, keyword_init: true)
DataNoSource = Struct.new(:source, :identifier, :type, keyword_init: true)

attr_reader :details

Expand Down Expand Up @@ -149,17 +148,7 @@ def compiled_source
format = self.format || ViewComponent::Base::VC_INTERNAL_DEFAULT_FORMAT
type = ActionView::Template::Types[format]

if handler.method(:call).parameters.length > 1
handler.call(
DataWithSource.new(format: format, identifier: @path, short_identifier: short_identifier, type: type),
this_source
)
# :nocov:
# TODO: Remove in v4
else
handler.call(DataNoSource.new(source: this_source, identifier: @path, type: type))
end
# :nocov:
handler.call(DataWithSource.new(format:, identifier: @path, short_identifier:, type:), this_source)
end
end
end
Loading