Skip to content

Revert "Migrate strip_trailing_whitespace to use component-local config under the hood" #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

joelhawksley
Copy link
Member

On v4, the remaining configuration options are:

{
    generate: default_generate_options,
    preview_controller: "ViewComponentsController",
    preview_route: "/rails/view_components",
    instrumentation_enabled: false,
    show_previews: Rails.env.development? || Rails.env.test?,
    preview_paths: default_preview_paths,
    test_controller: "ApplicationController",
    default_preview_layout: nil
}

While we had originally planned to move to component/engine-local config, I believe that we will be fine leaving these configuration values in their current architecture. As such, I am going to revert #2230.

@reeganviljoen, let's move forward with #1987 as a per-component option like strip_trailing_whitespace.

@joelhawksley joelhawksley merged commit e346071 into main May 21, 2025
24 of 25 checks passed
@joelhawksley joelhawksley deleted the revert-2230-component-local-config branch May 21, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant