Reduce allocations in Slotable#register_default_slots #2328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdelStrother
force-pushed
the
reduce-allocations
branch
from
5ca8fc0 to
872e5a8
Compare
jdelStrother
force-pushed
the
reduce-allocations
branch
from
872e5a8 to
e4c6682
Compare
|
I've struggled to reproduce those CI failures locally, are they something I've introduced? I wasn't sure how exhaustive the ruby-versions mentioned in render_inline_allocations were supposed to be, let me know if you rather I drop that commit |
joelhawksley
approved these changes
Jun 2, 2025
|
@jdelStrother those PVC failures are from the PVC test suite being tied to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While profiling something unrelated I noticed a lot of unnecessary string allocations in Slotable#register_default_slots. How about this change to move it out of the
instance_methodsloop?