Fix: missing generators in gemfiles#2395
Merged
joelhawksley merged 2 commits intoViewComponent:mainfrom Jul 21, 2025
Merged
Conversation
there's no `lib/rails` folder but there is a `lib/generators` folder, I believe this is a configuration bug that was introduced during a v4-related refactoring?
Jell
force-pushed
the
jl/fix-missing-generators
branch
from
64b8f74 to
f37e9e9
Compare
Contributor
Author
|
I'm not sure why the tests are failing after this change, I'm failing to understand if they are related or just flakey? I'm afraid I will have to let someone more knowledgeable about the codebase figure that out 😅 |
Contributor
Author
|
Digging further into it, since ruby 3.5 is installed from "head" I'm guessing a new optimization landed on the latest version of ruby 3.5 which leads to fewer allocations, so I don't believe this is related to my change. Probably the expectation on the number of allocations should be updated to reflect that new optimization? 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there's no
lib/railsfolder but there is alib/generatorsfolder, I believe this is a configuration bug that was introduced during a v4-related refactoring?What are you trying to accomplish?
Attempting to address: #2394
What approach did you choose and why?
I looked into the expected convention for rails generators, noticed that the
lib/generatorsfolder was missing in the install folder of the gem on my local machine.Anything you want to highlight for special attention from reviewers?
I'm hoping this is a simple typo / oversight, which I believe a maintainer should be able to quickly figure out from this PR! 😅
I am not entirely sure how to write a spec for this, but perhaps that's not necessary for a gemspec typo?