Skip to content

Commit 52439f7

Browse files
committed
fix release publish, tidy the docker eval stack
1 parent b18873d commit 52439f7

5 files changed

Lines changed: 17 additions & 8 deletions

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,12 @@ jobs:
138138
if: startsWith(github.ref, 'refs/tags/')
139139
runs-on: ubuntu-24.04
140140
steps:
141+
# Tarballs only. The docker job also leaves a .dockerbuild build record
142+
# artifact behind, and pulling that one fails the whole download.
141143
- uses: actions/download-artifact@v4
142-
with: { path: dist, merge-multiple: true }
144+
with: { path: dist, pattern: '{linux,macos}-*', merge-multiple: true }
143145
- uses: softprops/action-gh-release@v2
144146
with:
145147
files: dist/*.tar.gz
148+
fail_on_unmatched_files: true
146149
generate_release_notes: true

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ export LD_LIBRARY_PATH=/usr/local/cuda/lib64:$LD_LIBRARY_PATH
7070

7171
Check [docs/backend](docs/backend) for compiling `vla.cpp` on other platforms.
7272
WSL2, Apple Silicon, and Intel GPU are all tested.
73+
To build and run in containers instead, see [docs/DOCKER.md](docs/DOCKER.md).
7374

7475
---
7576

docs/DOCKER.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,12 @@ Build args accepted by the server `Dockerfile`:
5252
| Arg | Default | Notes |
5353
|-----|---------|-------|
5454
| `BACKEND` | `cuda` | `cuda` or `cpu` |
55-
| `CUDA_ARCH` | `120` | Blackwell; `89` for RTX40, `87` for Orin, `86` for RTX30 |
55+
| `CUDA_ARCH` | `120` in Compose, `89` in the `Dockerfile` | Blackwell; `89` for RTX40, `87` for Orin, `86` for RTX30 |
5656
| `BASE_IMAGE` | `nvidia/cuda:12.9.1-devel-ubuntu24.04` | Set to `ubuntu:24.04` when building a CPU image |
5757
| `JOBS` | `nproc` | Lower if nvcc segfaults on flash-attn kernels |
5858

59-
Override via e.g. `docker compose -f eval/docker-compose.yml build --build-arg CUDA_ARCH=89 server`.
59+
Override the arch from the environment, `CUDA_ARCH=89 docker compose -f eval/docker-compose.yml build server`,
60+
or per build, `docker compose -f eval/docker-compose.yml build --build-arg CUDA_ARCH=89 server`.
6061

6162
### 3. Start the server
6263

eval/Dockerfile.client

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ RUN update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.10 1
5555
RUN curl -sS https://bootstrap.pypa.io/get-pip.py | python3.10
5656

5757
WORKDIR /workspace/vla.cpp
58-
COPY . .
5958

6059
# ---------------------------------------------------------------------------
6160
# Python dependencies — order matters to avoid version conflicts
@@ -96,7 +95,7 @@ RUN pip3 install lerobot==0.4.3 && \
9695
RUN pip3 install \
9796
transformers==4.51.3 \
9897
gymnasium==0.29.1 \
99-
zmq \
98+
pyzmq \
10099
msgpack==1.1.0 \
101100
msgpack-numpy==0.4.8 \
102101
pillow \
@@ -112,7 +111,7 @@ RUN pip3 install \
112111
albumentations==1.4.18 \
113112
pyarrow==12.0.1 \
114113
diffusers==0.30.1 \
115-
huggingface-hub
114+
huggingface-hub==0.35.3
116115

117116
# Re-pin numpy to 1.x — later deps (albumentations, tianshou, etc.) pull in 2.x
118117
RUN pip3 install numpy==1.26.4
@@ -124,4 +123,8 @@ RUN sed -i 's/np_core = np._core if is_numpy_available("2.0.0") else np.core/np_
124123
# Clean up pip cache to keep image size small
125124
RUN rm -rf /root/.cache/pip
126125

126+
# The repo goes last: it changes every commit, and everything above it is a
127+
# half-hour of installs worth caching.
128+
COPY . .
129+
127130
CMD ["bash"]

eval/docker-compose.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,16 @@ services:
2222
# vla-server — C++ inference daemon (upstream Dockerfile)
2323
# Build args:
2424
# BACKEND=cuda|cpu (default: cuda)
25-
# CUDA_ARCH (default: 120, use 89 for RTX40, 87 for Orin, etc.)
25+
# CUDA_ARCH (from the environment, default 120; 89 for RTX40, 87 for Orin)
26+
# e.g. CUDA_ARCH=89 docker compose -f eval/docker-compose.yml build server
2627
# --------------------------------------------------------------------------
2728
server:
2829
build:
2930
context: ..
3031
dockerfile: Dockerfile
3132
args:
3233
BACKEND: cuda
33-
CUDA_ARCH: "120"
34+
CUDA_ARCH: "${CUDA_ARCH:-120}"
3435
image: vla-cpp-server
3536
container_name: vla-cpp-server
3637
devices:

0 commit comments

Comments
 (0)