Expose lvt LocalVariable to renaming plugins, add simple renamer that fixes conflicting lvt names #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a 21 (Vineflower#355) * Fix switches with enums for enums in other classes and null cases * Remove println
* Fix if statements inside switch statements preventing switch expressions * Update test output * Fix switch statements that throw an exception not being converted * Add comment
…o arguments (Vineflower#362) * Fix formatter emitting blank lines for long method invocations with no arguments fixes Vineflower#359 * Simplify test
…#361) * Fix local class methods not getting the parent context * Add test
…ne (Vineflower#363) fixes Vineflower#359 (for real this time?)
…ineflower#366) They may be needed later when writing other classes. This fixes an issue where non-static inner class constructor invocations from foreign classes would inconsistently have the synthetic enclosing this instance removed from the parameter list, depending on the order they were processed in (and consequently having strange interactions with multithreaded writing)
* Don't write explicit casts where redundant * Fix numeric parameter disambiguation * Write casts when not doing so would change behavior * Fix failing test --------- Co-authored-by: Jasmine Karthikeyan <[email protected]>
… fixes conflicting lvt names
jaskarth
added
Type: Enhancement
jaskarth
force-pushed
the
develop/1.11.0
branch
2 times, most recently
from
a6698b7 to
0be304f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing the lvt allows renamers to use any existing name in consideration for renaming.
Also adds a renamer that fixes conflicting lvt names, which is helpful for example with tiny-remapper output (as it does not take into account names used by enclosing methods).