Add checks for generic types and discard any unexpected types #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do these checks work when signatures depend on each other? For example, a field that initially has a valid signature, but its type class's signature does not pass the check and is modified/removed, which in turn then invalidates that field's signature. |
jaskarth
force-pushed
the
develop/1.11.0
branch
2 times, most recently
from
a6698b7 to
0be304f
Compare
|
I think you may need to rebase off of 1.12.0 for this, the diff and history have been pretty mangled. Thanks! |
jaskarth
added
Subsystem: Generics
Also upload the intended test result for TestCorruptedSignatures
sschr15
force-pushed
the
fix/mismatched-generics
branch
from
1c14529 to
e07b7f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #409 by adding checks and discarding any clearly bogus generics