Properly walk the inheritance tree when checking for possibly ambiguous unboxed calls #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us unboxing calls
Owen1212055
force-pushed
the
fix/superclass-boxing
branch
from
536691b to
419e6dc
Compare
Owen1212055
changed the title
jaskarth
approved these changes
Dec 16, 2024
Member
jaskarth
left a comment
jaskarth
left a comment
There was a problem hiding this comment.
Looks good, thanks for the fix!
jaskarth
added
Subsystem: Writing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issues when unboxing seems to not occur on method invocations that occur on superclass methods.
This most notably improves readability of certain codecs / block state definitions.
public static final Codec<DisplayInfo> CODEC = RecordCodecBuilder.create( instance -> instance.group( ItemStack.STRICT_CODEC.fieldOf("icon").forGetter(DisplayInfo::getIcon), ComponentSerialization.CODEC.fieldOf("title").forGetter(DisplayInfo::getTitle), ComponentSerialization.CODEC.fieldOf("description").forGetter(DisplayInfo::getDescription), ResourceLocation.CODEC.optionalFieldOf("background").forGetter(DisplayInfo::getBackground), AdvancementType.CODEC.optionalFieldOf("frame", AdvancementType.TASK).forGetter(DisplayInfo::getType), - Codec.BOOL.optionalFieldOf("show_toast", Boolean.valueOf(true)).forGetter(DisplayInfo::shouldShowToast), - Codec.BOOL.optionalFieldOf("announce_to_chat", Boolean.valueOf(true)).forGetter(DisplayInfo::shouldAnnounceChat), - Codec.BOOL.optionalFieldOf("hidden", Boolean.valueOf(false)).forGetter(DisplayInfo::isHidden) + Codec.BOOL.optionalFieldOf("show_toast", true).forGetter(DisplayInfo::shouldShowToast), + Codec.BOOL.optionalFieldOf("announce_to_chat", true).forGetter(DisplayInfo::shouldAnnounceChat), + Codec.BOOL.optionalFieldOf("hidden", false).forGetter(DisplayInfo::isHidden) ) .apply(instance, DisplayInfo::new) );this.registerDefaultState( this.stateDefinition .any() - .setValue(DISTANCE, Integer.valueOf(7)) - .setValue(WATERLOGGED, Boolean.valueOf(false)) - .setValue(BOTTOM, Boolean.valueOf(false)) + .setValue(DISTANCE, 7) + .setValue(WATERLOGGED, false) + .setValue(BOTTOM, false) );