Prevent NPE on #getRecordComponents for Object #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earthcomputer
approved these changes
Feb 26, 2025
Requesting the record components from a struct class has a fallback to an empty list over null for objects that extend j.l.Record but do not have a record attribute. This fallback however assumes that the type has a superclass, which is not the case of j.l.Object, causing a NPE.
lynxplay
force-pushed
the
bugfix/record-components-on-object-switch
branch
from
83476fc to
cd02c9a
Compare
|
Fixed commit type ™️ |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting the record components from a struct class has a fallback to
an empty list over null for objects that extend j.l.Record but do not
have a record attribute.
This fallback however assumes that the type has a superclass, which is
not the case for j.l.Object, causing a NPE.