Stricter type pattern matching rules #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vineflower's previous implementation of the type casting pattern matching in switch statements was not strict enough, considering any form of cast in the first expression of the case block a result of type pattern matching. This would incorrectly attempt to emit such type pattern matching source code for switches that simply yielded different types. This commit tightens the logic to consider a switch case a type pattern matching one if the first expression is a simple cast of the switch head's variable.
jaskarth
added
Subsystem: Statement Structure
lynxplay
deleted the
bugfix/incorrect-instance-of-assumptions-in-switch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vineflower's previous implementation of the type casting pattern
matching in switch statements was not strict enough, considering any
form of cast in the first expression of the case block a result of type
pattern matching.
This would incorrectly attempt to emit such type pattern matching source
code for switches that simply yielded different types.
This commit tightens the logic to consider a switch case a type pattern
matching one if the first expression is a simple cast of the switch
head's variable.