Skip to content

Delegate semicolons to plugins when possible #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2025
Merged

Delegate semicolons to plugins when possible #471

merged 3 commits into from
Aug 14, 2025

Conversation

@sschr15
Copy link
Member

@sschr15 sschr15 commented Mar 22, 2025

This also makes a small change to KotlinChooser to reduce the cost of PluginContext.getLanguageSpec calls by a significant amount

@sschr15 sschr15 requested a review from jaskarth March 22, 2025 03:04
@github-actions
Copy link

github-actions bot commented Mar 22, 2025 •
edited
Loading

Test Results

   18 files  ±0     18 suites  ±0   1m 6s ⏱️ -1s
1 939 tests ±0  1 938 ✅ ±0  1 💤 ±0  0 ❌ ±0 
2 574 runs  ±0  2 572 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 8a600af. ± Comparison against base commit 2e50dff.

♻️ This comment has been updated with latest results.

@sschr15 sschr15 mentioned this pull request Aug 23, 2024
Open
36 tasks
@jaskarth jaskarth added Priority: Medium Medium priority Type: Enhancement New feature or request Subsystem: Plugins Anything concerning the plugins system or plugin code labels Aug 14, 2025
@sschr15 sschr15 force-pushed the feature/semicolon-delegate branch from b6f7eee to 8a600af Compare August 14, 2025 17:00
jaskarth
jaskarth approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@jaskarth jaskarth merged commit 9e7e264 into develop/1.12.0 Aug 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaskarth jaskarth jaskarth approved these changes

Assignees

No one assigned

Labels

Priority: Medium Medium priority Subsystem: Plugins Anything concerning the plugins system or plugin code Type: Enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sschr15 @jaskarth