Skip to content

Conversation

@shartte
Copy link
Contributor

@shartte shartte commented Apr 22, 2025

When VF is embedded in a Shadow Jar and that Shadow Jar is previously opened as a ZipFS, then this may happen when the plugins are initialized:

java.nio.file.FileSystemAlreadyExistsException
        at jdk.zipfs/jdk.nio.zipfs.ZipFileSystemProvider.newFileSystem(ZipFileSystemProvider.java:104)
        at java.base/java.nio.file.FileSystems.newFileSystem(FileSystems.java:339)
        at java.base/java.nio.file.FileSystems.newFileSystem(FileSystems.java:288)
        at org.jetbrains.java.decompiler.main.plugins.JarPluginLoader.init(JarPluginLoader.java:24)
        at org.jetbrains.java.decompiler.main.Init.init(Init.java:19)
        at org.jetbrains.java.decompiler.main.Fernflower.<clinit>(Fernflower.java:228)
        at org.jetbrains.java.decompiler.main.decompiler.ConsoleDecompiler.<init>(ConsoleDecompiler.java:225)
        at org.jetbrains.java.decompiler.main.decompiler.ConsoleDecompiler.main(ConsoleDecompiler.java:178)
        at net.neoforged.snowblower.Generator.getDecompiledJar(Generator.java:711)
        at net.neoforged.snowblower.Generator.generate(Generator.java:532)
        at net.neoforged.snowblower.Generator.runInternal(Generator.java:365)
        at net.neoforged.snowblower.Generator.run(Generator.java:234)
        at net.neoforged.snowblower.Main.main(Main.java:130)

This PR aims to fix that by avoiding opening a URI based FS and instead tries to only use Path based FS.

@shartte shartte changed the base branch from master to develop/1.11.1 April 23, 2025 16:44
@jaskarth jaskarth changed the base branch from develop/1.11.1 to develop/1.12.0 August 14, 2025 15:18
@jaskarth jaskarth added Subsystem: IO Anything concerning the File I/O system Priority: High High priority bugfix Fixes a bug labels Aug 14, 2025
Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jaskarth jaskarth merged commit 1d17821 into Vineflower:develop/1.12.0 Aug 14, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a bug Priority: High High priority Subsystem: IO Anything concerning the File I/O system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants