Compact canonical constructor support #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaskarth
reviewed
Aug 14, 2025
| return !hideMethod; | ||
| } | ||
|
|
||
| private static int getParamCount(StructMethod mt, TextBuffer buffer, int indent, MethodWrapper methodWrapper, MethodDescriptor md, boolean isEnum, boolean init, boolean thisVar, GenericMethodDescriptor descriptor, int paramCount, boolean isInterface, int flags, StructClass cl) { |
There was a problem hiding this comment.
I think this could use a slightly more descriptive name, since it has side effects as well as returning the param count.
There was a problem hiding this comment.
Done! Yeah, this was certainly not the correct name.
jaskarth
added
Type: Enhancement
We do that already, there is one place that doesn't occur and that's because there is an annotation on the constructor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minecraft diff
Would love feedback on the method pruning, not sure if there is a prefered way I should be doing this.
Additionally, I have to store a flag that a method wrapper is a compact constructor as I prune the fields making the check no longer valid later in the code.