feat(VCST-3928): save for later optimistic response

[yuskithedeveloper]

Description

Removed saved for later mutations batching and implemented optimistic responses support so the client doesn't wait the server to respond to rerender

References

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-3928

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.35.0-pr-1956-5412-5412bdfc.zip

[yuskithedeveloper]

Closed until an optimistic response support for batched requests would be implemented

[cursor]

Bug: Optimistic Move Bug Causes UI Discrepancy

The moveFromSavedForLater optimistic response only removes items from the saved-for-later list but doesn't add them to the cart. This causes items to temporarily disappear from the UI until the server response arrives.

 

[cursor]

Bug: Optimistic UI Fails to Update Destination Lists

The optimistic responses for moveToSavedForLater and moveFromSavedForLater only simulate the removal of items from their source list. They don't also optimistically add these items to their destination list (saved for later or cart, respectively). This results in items temporarily disappearing from the UI until the server response arrives.

Additional Locations (1)

• client-app/shared/cart/composables/useSaveForLater.ts#L92-L101

 

[cursor]

Bug: Undefined Variable Causes Length Access Error

The movedItemIds variable might be undefined if vars.command?.lineItemIds is missing. Accessing .length on an undefined value in this case would lead to a TypeError.

Additional Locations (1)

• client-app/shared/cart/composables/useSaveForLater.ts#L86-L89

 

[yuskithedeveloper]

About Cursor comments

1. Product line items are removed from the cart (or 'saved for later' list) to enhance the user experience; however, they aren't added to the 'saved for later' list (or cart) until the request succeeds.
   This was done intentionally to avoid user interaction with phantom records (such as changing the buyable quantity for a product that is not present in the cart yet).

2. optimisticResponse method 'vars' parameter is passed by Apollo, it's not null or undefined and contains the command data

[cursor]

Bug: Bug

Optimistic responses for moving items to/from 'saved for later' are ignored if savedForLaterList.value is undefined. This happens when the savedForLaterList hasn't loaded yet, creating a race condition that prevents immediate UI updates.

 

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud